Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test data url to download.ros.org #18

Closed
dirk-thomas opened this issue Sep 28, 2013 · 5 comments
Closed

update test data url to download.ros.org #18

dirk-thomas opened this issue Sep 28, 2013 · 5 comments
Assignees

Comments

@dirk-thomas
Copy link

Please update the urls for test data from pr.willowgarage.com to download.ros.org.

  • velodyne_driver/CMakeLists.txt
  • velodyne_pointcloud/CMakeLists.txt
@ghost ghost assigned jack-oquin Sep 28, 2013
@jack-oquin
Copy link
Member

Does this require a new release, or just a source update?

@jack-oquin
Copy link
Member

I am guessing that no release is required, and that this only affects devel and pre-release tests.

Please re-open if that is wrong.

@dirk-thomas
Copy link
Author

Currently pr.willowgarage.com is still available and redirecting to the new location. As soon as that is not the case anymore it would require a new release since users usually build only released packages from source (http://wiki.ros.org/hydro/Installation/Source).

It is absolutely fine to not release it immediately. But you should release it if the redirect disappears and there has not been a new release by then.

@jack-oquin
Copy link
Member

Good point. I'll be releasing a new version sometime soon, anyway.

Meanwhile, I'm re-opening this issue so I don't forget about it.

@jack-oquin jack-oquin reopened this Sep 28, 2013
@jack-oquin
Copy link
Member

Fix released in velodyne-1.1.2, which is now built in ros-shadow-fixed.

vrabaud pushed a commit to vrabaud/velodyne that referenced this issue May 9, 2016
vrabaud pushed a commit to vrabaud/velodyne that referenced this issue May 9, 2016
vrabaud pushed a commit to vrabaud/velodyne that referenced this issue May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants