Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional parameters to launch files #14

Merged
merged 1 commit into from
Jul 30, 2013
Merged

add additional parameters to launch files #14

merged 1 commit into from
Jul 30, 2013

Conversation

gabor-meszaros
Copy link
Contributor

I wanted to add additional parameters to launch files. Maybe you also find it useful. I skipped the npackets parameter because it does not have meaningful default value.

jack-oquin added a commit that referenced this pull request Jul 30, 2013
add additional parameters to launch files
@jack-oquin jack-oquin merged commit 8953b9d into ros-drivers:master Jul 30, 2013
@bricerebsamen
Copy link
Contributor

I don't get it: I couldn't find any trace of those parameters in the C++ code. Aren't they used? Also what's their meaning?

@gabor-meszaros
Copy link
Contributor Author

Hi Brice!

You will find their usage in the code if you search "private_nh.param" in input.cc, rawdata.cc or driver.cc.

Their meaning are:

  • read_once: Should the driver read the input pcap file only once or until you stop it.
  • read_fast: Should the driver try to reproduce the timing during replay or it should just read as fast the pcap file as it can and publish the read data.
  • repeat_delay: If the driver reads the pcap file more than once, then this delay will be used between two reading.
  • rpm: You should give the used rpm during recording. Btw I think we can compute this value from the packages.
  • frame_id: If you want to change the default frame IDs.
  • min_range: The points those are closer to the device than this value will be omited.
  • max_range: The points those are further from the device than this value will be omited.

You can find more information about them (with the exception of read_once, read_fast and repeat_delay) in the documentation: velodyne_driver and velodyne_pointcloud.

@jack-oquin
Copy link
Member

The read_once, read_fast and repeat_delay parameters were intended mainly for testing purposes.

If you think they are generally useful, I'll add them to the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants