Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up PR 112 (add 20/2.50 and 40/2.55 variants to IRB 4600) #117

Merged
merged 6 commits into from
Jan 16, 2020

Conversation

gavanderhoorn
Copy link
Member

As per subject.

This is a cleaned up version of #112, which had too many commits and a very complex commit history.

I've kept provenance on all commits.

Locally tested, seems to be working.

@gavanderhoorn
Copy link
Member Author

As this is my "own" PR, I cannot review it any more. Hence the requests to other ros-i reviewers.

If any of you could review, I'll merge.

Note: I've reviewed this PR in its previous version (being #112). All my comments and requests have been addressed already.

@gavanderhoorn
Copy link
Member Author

@rtonnaer: could you perhaps also verify whether you're OK with these contributions?

Perhaps @dave992 could take a look as well and verify with the hw?

Copy link

@dejaniraai dejaniraai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@gavanderhoorn
Copy link
Member Author

Thanks @dejaniraai. I'll give @rtonnaer and @dave992 some time to respond as well.

Copy link
Member

@ipa-nhg ipa-nhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dave992
Copy link
Contributor

dave992 commented Jan 16, 2020

Looks good! I have just tested it on the hw and everything works as expected.

@gavanderhoorn
Copy link
Member Author

Thanks @ipa-nhg and @dave992 for checking.

I'm going to merge this.

@gavanderhoorn gavanderhoorn merged commit d41bfe3 into ros-industrial:kinetic-devel Jan 16, 2020
@gavanderhoorn gavanderhoorn deleted the pr112_cleaned_up branch January 16, 2020 17:25
@gavanderhoorn
Copy link
Member Author

Thanks for all the work @rtonnaer and for iterating 💯

I'll buy you a 🍺 some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants