-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaned up PR 112 (add 20/2.50 and 40/2.55 variants to IRB 4600) #117
Cleaned up PR 112 (add 20/2.50 and 40/2.55 variants to IRB 4600) #117
Conversation
Only for the visual meshes.
Visual meshes only again.
List new contributor as author and update info on supported variants.
As this is my "own" PR, I cannot review it any more. Hence the requests to other ros-i reviewers. If any of you could review, I'll merge. Note: I've reviewed this PR in its previous version (being #112). All my comments and requests have been addressed already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good.
Thanks @dejaniraai. I'll give @rtonnaer and @dave992 some time to respond as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Looks good! I have just tested it on the hw and everything works as expected. |
Thanks for all the work @rtonnaer and for iterating 💯 I'll buy you a 🍺 some time. |
As per subject.
This is a cleaned up version of #112, which had too many commits and a very complex commit history.
I've kept provenance on all commits.
Locally tested, seems to be working.