Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit 'support level' badge and pkg manifest element #232

Merged

Conversation

gavanderhoorn
Copy link
Member

As per subject.

To avoid potential conflicts with future other additions to the export element I added a ros_industrial 'namespace' with the support_level element as it's child. This is not documented anywhere, nor used at the moment.

The change to the repository-level readme adds the actual badge.

No functional changes.

@gavanderhoorn
Copy link
Member Author

If we agree this is ok I can submit PRs for the other ros-i repositories where this would make sense.

@gavanderhoorn
Copy link
Member Author

@ipa-mirb

@gavanderhoorn
Copy link
Member Author

I've removed (for now) the badge from the repository-level readme: it didn't render reliably for me.

I'll try to figure out a solution to this, but would like to get the additional keywords in the expert section merged.

@gavanderhoorn
Copy link
Member Author

@Levi-Armstrong: could I bother you for a review?

@gavanderhoorn
Copy link
Member Author

Thanks for the review.

@gavanderhoorn gavanderhoorn merged commit 35db153 into ros-industrial:indigo-devel Jan 10, 2018
@gavanderhoorn gavanderhoorn deleted the add_support_level branch January 10, 2018 19:31
gavanderhoorn added a commit to ros-industrial/fanuc_experimental that referenced this pull request Jan 10, 2018
gavanderhoorn added a commit to gavanderhoorn/fanuc that referenced this pull request Feb 28, 2019
gavanderhoorn added a commit to gavanderhoorn/fanuc that referenced this pull request Feb 28, 2019
gavanderhoorn added a commit to gavanderhoorn/fanuc that referenced this pull request Feb 28, 2019
gavanderhoorn added a commit to gavanderhoorn/fanuc that referenced this pull request Feb 28, 2019
gavanderhoorn added a commit to gavanderhoorn/fanuc that referenced this pull request Feb 28, 2019
gavanderhoorn added a commit to gavanderhoorn/fanuc that referenced this pull request Feb 28, 2019
gavanderhoorn added a commit to gavanderhoorn/fanuc that referenced this pull request Feb 28, 2019
gavanderhoorn added a commit to gavanderhoorn/fanuc that referenced this pull request Feb 28, 2019
gavanderhoorn added a commit to gavanderhoorn/fanuc that referenced this pull request Feb 28, 2019
gavanderhoorn added a commit to gavanderhoorn/fanuc that referenced this pull request Feb 28, 2019
gavanderhoorn added a commit to gavanderhoorn/fanuc that referenced this pull request Aug 26, 2019
gavanderhoorn added a commit to gavanderhoorn/fanuc that referenced this pull request Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants