Migrate R-1000iA support, moveit and plugin pkgs from experimental repository #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add preamble on all files except those generated by tools. - launch files - package manifests - roslaunch tests - xacros
These targets don't exist when using isolated builds or when packages are build that depend on binary distributions that provide the specified targets. Newer versions of CMake will print copious warnings about the targets not existing, so remove them.
. MoveIt previously defaulted to LBKPIECE which does not always result in consistent planning performance or logical/efficient/sensable trajectories. RRTConnect seems to perform better, hence it is set as the default. Note: this is a default planner, which is used only when planning requests don't specify one as part of the request.
'xacro.py' has been deprecated for some time now.
In preparation of future changes making use of the improved xacro supported in Jade and newer ROS releases.
Allows supporting libraries to check contents / structure of the manifests gainst the provided schema. See [1] for more information. [1] http://www.ros.org/reps/rep-0140.html#schema
For stand-alone use of the models, the top-level xacro macros should be used.
This adds basic roslaunch testing to all MoveIt configs in this repository. Only `demo.launch` and `moveit_planning_execution.launch` are tested for now, and the latter only in 'non-sim' mode due to a bug in roslaunch that causes it to not handle the optional argument `robot_ip` properly (as it has no default). `demo.launch` is tested directly, `moveit_planning_execution.launch` is tested through a small wrapper that supplies values for the required arguments. Finally, `roslaunch` is added as a `test_depend` to all package manifests.
These were discovered to be missing after adding roslaunch tests.
As of 7e14866 we don't use our own 'pi' anymore, so the constants xacro is no longer needed. Ref: ros-industrial/fanuc@822ff1a.
Appease catkin_lint.
gavanderhoorn
force-pushed
the
migrate_r1000ia
branch
from
e5c8d58
to
b675df4
Compare
gavanderhoorn
force-pushed
the
migrate_r1000ia
branch
from
b675df4
to
91f6794
Compare
shaun-edwards
approved these changes
Mar 25, 2019
|
Thanks @shaun-edwards 👍 |
gavanderhoorn
added a commit
to ros-industrial/fanuc_experimental
that referenced
this pull request
Mar 27, 2019
Moved to ros-industrial/fanuc in ros-industrial/fanuc#251.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per subject.
This migrates all packages related to the R-1000iA from
fanuc_experimentaltofanuc, with the commit history that touches those packages.This obviously leads to duplicate commits (as many touch multiple packages) and changes hashes, but there is no way to maintain the original commits while also importing them into this repository. At least this way the full history is present here as well. PR and issue references have been updated where necessary to still refer to
fanuc_experimental.No functional changes have been made to any of the packages. This is a straight import of the artefacts from
fanuc_experimentalwith only some minor updates to the package manifests (such as references tofanuc_experimentaland the wiki).