Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to std_srvs/Trigger instead of cob_srvs/Trigger #88

Closed
floweisshardt opened this issue Apr 17, 2015 · 4 comments
Closed

switch to std_srvs/Trigger instead of cob_srvs/Trigger #88

floweisshardt opened this issue Apr 17, 2015 · 4 comments

Comments

@floweisshardt
Copy link

std_srvs/Trigger is in the release pipeline already, see ros/rosdistro#7964.

we'll need to change the dependencies to use std_srvs/Trigger instead of cob_srvs/Trigger

@mathias-luedtke
Copy link
Member

In addition all simple_script_sever-related interfaces must be adapted, including other component drivers.

@fmessmer
Copy link
Contributor

I can do the non-ros_canopen part...

@fmessmer
Copy link
Contributor

I did this for all bringup repositories:

All other repos do not use Trigger - or did I miss something?

I leave ros_canopen for @ipa-mdl
What about ipa_canopen? For compatibility reasons?

I'd adjust cobvid and hmi_2015 on Wednesday!

Any other packages where we need to change the service?


We can keep cob_srvs/Trigger.srv for a while longer, so that we do not break anything...as we do not know who else is using it....

@floweisshardt
Copy link
Author

good work @ipa-fxm! I can't think of any other repository.

But I'd like to remove cob_srvs/Trigger because it add no additional value compared to std_srvs/Trigger. By removing cob_srvs/Trigger we assure that it pops up if it is still used anywhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants