Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibrated URDF (rebased on-top of melodic-devel-staging) #495

Conversation

gavanderhoorn
Copy link
Member

This is @fmauch's work but rebased on-top of melodic-devel-staging.

the kinematics parameters can be retrieved from a calibration mechanism
to precisely represent the robot's kinematics.
@gavanderhoorn gavanderhoorn mentioned this pull request Jun 6, 2020
@gavanderhoorn
Copy link
Member Author

@fmauch: I'm going to merge this, but you may have updates or fixes you'd want to contribute.

We can do that in a follow-up PR.

@fmauch
Copy link
Contributor

fmauch commented Jun 6, 2020

There definitely are things I'd like to update. But merging this and making a separate PR is fine with me :-)

@gavanderhoorn gavanderhoorn mentioned this pull request Jun 6, 2020
7 tasks
@gavanderhoorn gavanderhoorn merged commit e98d41a into ros-industrial:melodic-devel-staging Jun 6, 2020
@gavanderhoorn gavanderhoorn deleted the calibration_fmauch_rebased branch June 6, 2020 10:55
@gavanderhoorn
Copy link
Member Author

Thanks @fmauch for the contribution 👍

gavanderhoorn pushed a commit that referenced this pull request Jun 6, 2020
the kinematics parameters can be retrieved from a calibration mechanism
to precisely represent the robot's kinematics.
@gavanderhoorn
Copy link
Member Author

I botched up the author<->committer, so force-pushed a fix.

Commit is now 9245b38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants