ur_description: Use the per-model xacro files for correct robot name #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the common xacro file the robot name will always be "ur". However, the moveit config packages expect the robot name to be e.g. "ur10e". This commit will use the macros containing the model name already.
gavanderhoorn
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
I'm not too thrilled about the robot_model argument (should it be called 'variant'?), as this adds yet another argument to an already long list.
But it's not exposed to users (they probably don't want to use the base load_ur.launch) and it does solve the problem.
|
Thanks @fmauch 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the common xacro file the robot name will always be "ur".
However, the moveit config packages expect the robot name to be e.g. "ur10e".
This commit will use the macros containing the model name already.
This fixes #585 and should help in #538.