Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote rep 142 indigo metapackages to active #72

Merged
merged 6 commits into from May 8, 2014
Merged

promote rep 142 indigo metapackages to active #72

merged 6 commits into from May 8, 2014

Conversation

tfoote
Copy link
Member

@tfoote tfoote commented Apr 24, 2014

No description provided.

@adolfo-rt
Copy link

On the ros_base package list: nodeliet_corenodelet_core

@mikeferguson
Copy link

Looks good, the only thing that seems odd to me is that "viz" extends "robot", and includes rqt_common_plugins, but does not include rqt_robot_plugins? @dirk-thomas is there some issue with rqt_robot_plugins that keeps it from being in viz?

Minor type on first box: "nodeliet_core" should be "nodelet_core"

@vrabaud
Copy link
Contributor

vrabaud commented Apr 24, 2014

instition mispells institution

@jack-oquin
Copy link
Contributor

roscore: extends is missing close bracket:

- ros_core:
     extends: [ros, ros_comm,

@mikepurvis
Copy link
Contributor

Not sure where it should fit, but it would be great to have roslint installed somewhere here. It's being used by a handful of packages in Hydro and Indigo right now, but only ever as a build dependency, so it won't get installed along with other things unless manually or via rosdep.

@dirk-thomas
Copy link
Member

@adolfo-rt @mikeferguson @vrabaud @jack-oquin Thank you finding the spelling / syntax issues. They have been addressed in the recent commit.

@mikeferguson I do agree, we should switch from rqt_common_plugins to rqt_robot_plugins in the viz metapackage - all the dependencies seems to be there anyway. @tfoote Agree?

@mikepurvis Adding roslint sounds like a very good idea. What about adding it to desktop?

@mikepurvis
Copy link
Contributor

Desktop sounds right to me; it's a development tool, so that's the logical spot.

@tfoote
Copy link
Member Author

tfoote commented Apr 24, 2014

+1 on the plugins.

+1 for roslint in desktop

@tkruse
Copy link
Contributor

tkruse commented Apr 24, 2014

ros_base seems to extend ros_core, should be listed after ros_core.

@wjwwood
Copy link
Contributor

wjwwood commented Apr 24, 2014

+1

@jack-oquin
Copy link
Contributor

+1 looks good to me

tfoote added a commit that referenced this pull request May 8, 2014
promote rep 142 indigo metapackages to active
@tfoote tfoote merged commit 53a7397 into master May 8, 2014
@tfoote tfoote deleted the rep_142 branch May 8, 2014 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants