Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -dbgsym packages from diff by default #181

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

peci1
Copy link

@peci1 peci1 commented Jul 7, 2023

No description provided.

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/new-packages-for-iron-irwini-2023-06-30/32169/6

scripts/diff_packages.py Outdated Show resolved Hide resolved
@peci1
Copy link
Author

peci1 commented Jul 8, 2023

Okay, I haven't known there isn't a way to run this script locally. I updated the PR so that the dbgsym packages are not counted in the totals and are merged to the line with their base package:

Added Packages [16]:
 * ros-noetic-chaplus-ros: 2.1.26-1
 * ros-noetic-cras-imu-tools: 1.0.1-1 (+debug symbols ros-noetic-cras-imu-tools-dbgsym)

As the debug packages can be (in theory) added/removed independently of their base packages, I tried to reflect their added/updated/removed state by using +debug symbols, debug symbols and -debug symbols. I'm not sure whether this is worth it, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants