Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tf2 include and tf2 exception type #103

Merged
merged 2 commits into from
Feb 14, 2018

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Feb 14, 2018

This fixes two issues that will be present in ROS Melodic due to ros/robot_state_publisher#82.

Currently <robot_state_publisher/robot_state_publisher.h> includes <tf/tf.h> which includes <tf2_ros/buffer.h> and <tf/exceptions.h>. Starting in ROS Melodic robot_state_publisher won't include any tf 1 headers.

@mikaelarguedas
Copy link
Member

Thanks @sloretz!

@nlyubova
Copy link
Member

Thank you @sloretz!

@nlyubova nlyubova merged commit a83ec33 into ros-naoqi:master Feb 14, 2018
@sloretz sloretz deleted the missing_tf2_include branch February 14, 2018 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants