Add lifecycle node compatibility to camera_info_manager #190
Conversation
Rayman
force-pushed
the
feature/camera-info-manager-lifecycle
branch
from
1ec6666
to
efac43b
Compare
|
Hey, can I get some feedback about this PR? |
| node->get_node_services_interface(), node->get_node_logging_interface(), cname, url) | ||
| { | ||
| } | ||
|
|
There was a problem hiding this comment.
Could you also add an overloaded constructor that takes in the rclcpp::LifecycleNode* that calls the constructor in L88?
There was a problem hiding this comment.
I've add the constructor. To do this, I had to add a dependency on rclcpp_lifecycle
Rayman
force-pushed
the
feature/camera-info-manager-lifecycle
branch
2 times, most recently
from
8524ee9
to
146901f
Compare
|
@mjcarroll do you have time to take a look at this? |
Rayman
force-pushed
the
feature/camera-info-manager-lifecycle
branch
2 times, most recently
from
dd188be
to
3097069
Compare
|
I've resolved the merge conflict |
|
CI:
|
|
Another stab at CI:
|
|
Please fix the build errors and update your branch. When you do that, I will run CI again. Most likely your branch is out of date. |
Rayman
force-pushed
the
feature/camera-info-manager-lifecycle
branch
from
3097069
to
ce01db1
Compare
|
Thanks. Here's some more CI.
|
|
Looks like I needed a new
|
|
We still have some build failures caused by this PR. Please take a look and fix the errors. |
Sorry that it's taking a bit of time, at my work we are still on ROS1 so I have to make some dedicated time free to figure out why it's not building. |
|
Seems to be fixed now |
|
|
CI looks good! Thanks for the work. |
This PR is similar to #167. It adds lifecycle node support only to the
camera_info_manager. It is backwards compatible.