Update setup.cfg to use underscores per setuptools preferred syntax #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JWhitleyWork
approved these changes
Aug 11, 2021
jacobperron
approved these changes
Nov 11, 2021
knzo25
added a commit
to tier4/image_pipeline
that referenced
this pull request
Mar 4, 2022
* Update camera_calibration setup.cfg to use underscores (ros-perception#688) Fixes a deprecation warning. * trimmed whitespace at line endings * implemented fisheye mono and stereo calibration based on the melodic branch * rebase change * fixes to pass tests * update pytest.ini * added missing imports * revert back * Add retry video capture feature with timeout Retry onInit() if the loading image fails or if the image is empty. This is useful if the stream is lost for a while or if the stream is not ready in the beginning. * Warning instead of fatal error when frames are differents Signed-off-by: Francisco Martin Rico <fmrico@gmail.com> * Fix tiny error in comment Signed-off-by: Francisco Martin Rico <fmrico@gmail.com> * Use RCLCPP_WARN_THROTTLE (10 secs) to avoid terminal spam Signed-off-by: Francisco Martín Rico <fmrico@gmail.com> * add xyzrgb radial node * use unique_ptrs, remove unused code, add back in missing initMatrix call Signed-off-by: Evan Flynn <evan.flynn@apex.ai> * bring over ros1 fix for missing roi resize Signed-off-by: Evan Flynn <evan.flynn@apex.ai> * Add tracetools_image_pipeline package to the pipeline Add an LTTng tracing provider wrapper for image_pipeline metapackage. Include tracepoints for two initial ROS 2 components: image_proc::RectifyNode and ResizeNode Signed-off-by: Víctor Mayoral Vilches <v.mayoralv@gmail.com> * LTTng instrument image_proc::RectifyNode and image_proc::ResizeNode Signed-off-by: Víctor Mayoral Vilches <v.mayoralv@gmail.com> * Deal with uncrustify and cpplint Signed-off-by: Víctor Mayoral Vilches <v.mayoralv@gmail.com> * Omit changelogfile See ros-perception#717 (comment) Signed-off-by: Víctor Mayoral Vilches <v.mayoralv@gmail.com> * tracetools_image_pipeline version consistent with repo Signed-off-by: Víctor Mayoral Vilches <v.mayoralv@gmail.com> * Remove unnecessary find_package tracetools_image_pipeline included in package.xml and fetched by ament_auto_find_build_dependencies(). Signed-off-by: Víctor Mayoral Vilches <v.mayoralv@gmail.com> * Fixed the occupation percetnage drawings Fixed the deadlock caused by using GUI calls in different threads by moving all those calls to the main thread The calibrator was missing the major part of the frames and the window did not get updated due to the threading model. Test indicates that just by properly changing the model to a classic consumer/producer solves the particular issue without any side effects * Fixed the 'proper' camera calibration part. This time using the bag recorded on the 01/31, the results seem coherent, but have not been tested * Changed the locks by deques to match the original code in style. These structures are thread-safe so they replace the manual locks * Fixed typo in pointcloudxyz launch file * Fixed the code from the upstream (this branch also has tieriv code) * Fixed import error during merge Co-authored-by: jaiveersinghNV <84546269+jaiveersinghNV@users.noreply.github.com> Co-authored-by: Gabor Soros <gabor.soros@nokia-bell-labs.com> Co-authored-by: Patrick Musau <pmusau13ster@gmail.com> Co-authored-by: Ashwin Sushil <ashwinsushil@yahoo.com> Co-authored-by: Francisco Martin Rico <fmrico@gmail.com> Co-authored-by: Evan Flynn <evanflynn.msu@gmail.com> Co-authored-by: Evan Flynn <evan.flynn@apex.ai> Co-authored-by: Víctor Mayoral Vilches <v.mayoralv@gmail.com> Co-authored-by: Harshal Deshpande <hardesh1deshpande@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building this package from source using
colcon build,camera_calibrationproduces the following warning:This PR fixes the two lines that cause this issue in the package's
setup.cfgfile.