Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

camera_calibration: Move approxsync.py to ros_comm #76

Closed
jbohren opened this issue Jun 2, 2014 · 5 comments
Closed

camera_calibration: Move approxsync.py to ros_comm #76

jbohren opened this issue Jun 2, 2014 · 5 comments

Comments

@jbohren
Copy link

jbohren commented Jun 2, 2014

The python approximate time synchronizer should really be moved into ros_comm

@colincsl
@jbohren jbohren mentioned this issue Jun 2, 2014
Closed
@jbohren
Copy link
Author

jbohren commented Jun 2, 2014

ros/ros_comm#424

@vrabaud
Copy link
Contributor

vrabaud commented Jun 3, 2014

before indigo I guess ?

@vrabaud
Copy link
Contributor

vrabaud commented Jun 5, 2014

That file should be removed and it should use the official Python one at:
https://github.com/ros/ros_comm/blob/indigo-devel/utilities/message_filters/src/message_filters/__init__.py#L101

@colincsl
Copy link

colincsl commented Jun 5, 2014

@vrabaud, the one you pointed to requires that all timestamps have the same time. The approximate time synchronizer has a 'slop' value so that time stamps don't need to be exactly the same.

vrabaud added a commit to vrabaud/image_pipeline that referenced this issue Jun 7, 2014
@vrabaud
fixes ros-perception#76
153e1e0 
Move Python approximate time synchronizer to ros_comm
@vrabaud
Copy link
Contributor

vrabaud commented Jun 8, 2014

@colincsl yop, I had not seen that thx. The MR is in ros/ros_comm#424 , please confirm it suits your needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@colincsl @vrabaud @jbohren