Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message_filters: Incorporate python approximate time synchronizer #424

Closed
jbohren opened this issue Jun 2, 2014 · 5 comments
Closed

message_filters: Incorporate python approximate time synchronizer #424

jbohren opened this issue Jun 2, 2014 · 5 comments

Comments

@jbohren
Copy link
Member

jbohren commented Jun 2, 2014

ros-perception/image_pipeline#76

@dirk-thomas
Copy link
Member

Please consider providing a pull request for this feature and also contribute to the documentation for it.

@vrabaud
Copy link
Member

vrabaud commented Jun 5, 2014

@vrabaud
Copy link
Member

vrabaud commented Jun 5, 2014

sorry, I missed it, this is approximate: should I create a new class or just add a slop parameter like done in the camera_calibration file ? (that would default to infinity I guess)

@tfoote
Copy link
Member

tfoote commented Jun 5, 2014

A parameter seems reasonable. though i'd make the slop default to zero ;-)

For ease of use it might be worth implementing it in the regular syncronizer using a semi protected method, and then have a separate wrapper class which invokes that code path and provides the clear interface.

vrabaud added a commit to vrabaud/ros_comm that referenced this issue Jun 7, 2014
incorporates the appximate time synchronizer that used to be in camera_calibration
vrabaud added a commit to vrabaud/ros_comm that referenced this issue Jun 7, 2014
incorporates the approximate time synchronizer that used to be in camera_calibration
@vrabaud
Copy link
Member

vrabaud commented Jun 8, 2014

guys, it's good, please review #433

dirk-thomas added a commit that referenced this issue Jun 10, 2014
rsinnet pushed a commit to MisoRobotics/ros_comm that referenced this issue Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants