New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image_rotate: clean up #862
Conversation
"Topic 'image' has not been remapped! Typical command-line usage:\n" | ||
"\t$ ros2 run image_rotate image_rotate image:=<image topic>"); | ||
return 1; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This debug message didn't work at all - made a more robust version by checking the overlap of our topic name with the actual topics that exist (as many of our depth_image_proc stuff does)
if (subscriber_count_) { // @todo: Could do this without an interruption at some point. | ||
unsubscribe(); | ||
subscribe(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is unneeded - none of the parameters that are able to be updated would impact how the subscribers would actually be setup
This is the first component/node with a cleanup pass to be fully implemented: