Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ros2 version: image_rotate does not initialize the target and source _vectors in constructor #740

Closed
dcconner opened this issue Apr 4, 2022 · 2 comments · Fixed by #862
Closed

ros2 version: image_rotate does not initialize the target and source _vectors in constructor #740

dcconner opened this issue Apr 4, 2022 · 2 comments · Fixed by #862
Assignees
@mikeferguson
Labels
bug ros2

Comments

@dcconner
Copy link

dcconner commented Apr 4, 2022

Need to add the following after onInit() call to update data; target_vector and source_vector default to zero

`
target_vector_.vector.x = config_.target_x;
target_vector_.vector.y = config_.target_y;
target_vector_.vector.z = config_.target_z;

source_vector_.vector.x = config_.source_x;
source_vector_.vector.y = config_.source_y;
source_vector_.vector.z = config_.source_z;

`
@dcconner dcconner changed the title foxy version: image_rotate does not initialize the target and source _vectors in constructor ros2 version: image_rotate does not initialize the target and source _vectors in constructor Apr 4, 2022
@clalancette
Copy link
Contributor

Can you please open a pull request with that change so we can review it? Thanks.

@dcconner dcconner mentioned this issue May 1, 2022
Closed
@dcconner
Copy link
Author

dcconner commented May 1, 2022

I verified compilation for image_rotate, but I went in another direction and developed a new node for ROS 2 I called image_flip that I present in PR #743 for review . I'm not set up to fully test this PR

@mikeferguson mikeferguson mentioned this issue Jan 19, 2024
Merged
@mikeferguson mikeferguson self-assigned this Jan 19, 2024
mikeferguson added a commit that referenced this issue Jan 19, 2024
@mikeferguson
image_rotate: clean up (#862)
21e5f25 
This is the first component/node with a cleanup pass to be fully
implemented:

* Fix #740 by initializing vectors. Do this by declaring parameters
AFTER we define the callback
 * Implement lazy subscribers (I missed this in the earlier PRs)
* Add image_transport parameter so we can specify that desired transport
of our subscriptions
* Update how we test for connectivity (and update the debug message -
has nothing to do with whether we are remapped, it's really about
whether we are connected)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikeferguson mikeferguson

Labels
bug ros2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

image_rotate: clean up mikeferguson/image_pipeline
3 participants
@dcconner @clalancette @mikeferguson