Add a class callback based version of the my_subscriber tutorial #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jack-Spleenlab
changed the title
|
This PR targeted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands on the my_subscriber.cpp tutorial by making it usable in a class. I am open to feedback on how we could make the code better, understandable, or more usable before merging.
I understand that this type of application is in some ways already solved by the
image_transport::SimpleSubscriberPlugintutorial but I think it is not a bad idea to offer the user this additional tutorial as it bridges the gap in understanding between the plugin tutorial and themy_subscribertutorial.It essentially answers this open issue: #3
Cheers!
Jack