Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rolling] Get user specified parameters at startup #46

Merged
merged 2 commits into from
May 16, 2024
Merged

[rolling] Get user specified parameters at startup #46

merged 2 commits into from
May 16, 2024

Conversation

john-maidbot
Copy link
Collaborator

@john-maidbot john-maidbot commented May 13, 2024 •
edited
Loading

rolling version of #45

@john-maidbot john-maidbot marked this pull request as ready for review May 13, 2024 14:38
@john-maidbot john-maidbot mentioned this pull request May 13, 2024
Closed
@john-maidbot john-maidbot requested a review from ahcorde May 13, 2024 14:41
@john-maidbot john-maidbot self-assigned this May 13, 2024
@ahcorde
Copy link
Collaborator

ahcorde commented May 15, 2024

@ros-pull-request-builder retest this please

@ahcorde
Copy link
Collaborator

ahcorde commented May 15, 2024

@john-maidbot CI is fixed here #47

@ahcorde ahcorde merged commit 46f3d22 into rolling May 16, 2024
4 of 5 checks passed
@ahcorde ahcorde deleted the john-maidbot/rolling/get-parameters-at-startup branch May 16, 2024 07:53
@ahcorde
Copy link
Collaborator

ahcorde commented May 16, 2024

https://github.com/Mergifyio backport jazzy humble iron

@mergify Mergify
Copy link

mergify bot commented May 16, 2024 •
edited
Loading

backport jazzy humble iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 16, 2024
@john-maidbot @mergify
Get user specified parameters at startup (#46)
cc6301a 
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 46f3d22)
@mergify mergify bot mentioned this pull request May 16, 2024
Merged
mergify bot pushed a commit that referenced this pull request May 16, 2024
@john-maidbot @mergify
Get user specified parameters at startup (#46)
2cf3a0b 
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 46f3d22)
mergify bot pushed a commit that referenced this pull request May 16, 2024
@john-maidbot @mergify
Get user specified parameters at startup (#46)
f5cf30b 
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 46f3d22)
This was referenced May 16, 2024
Merged
Merged
ahcorde pushed a commit that referenced this pull request May 20, 2024
@mergify @john-maidbot
Get user specified parameters at startup (#46) (#51)
3165a8c 
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 46f3d22)

Co-authored-by: john-maidbot <78750993+john-maidbot@users.noreply.github.com>
ahcorde pushed a commit that referenced this pull request May 24, 2024
@mergify @john-maidbot
Get user specified parameters at startup (#46) (#49)
447a27f 
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 46f3d22)

Co-authored-by: john-maidbot <78750993+john-maidbot@users.noreply.github.com>
ahcorde pushed a commit that referenced this pull request May 24, 2024
@mergify @john-maidbot
Get user specified parameters at startup (#46) (#50)
ed99d5e 
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 46f3d22)

Co-authored-by: john-maidbot <78750993+john-maidbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

@john-maidbot john-maidbot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-maidbot @ahcorde