Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add opencv_apps, proposed in #40 #56

Merged
merged 1 commit into from
Jan 4, 2015
Merged

add opencv_apps, proposed in #40 #56

merged 1 commit into from
Jan 4, 2015

Conversation

k-okada
Copy link
Contributor

@k-okada k-okada commented Dec 31, 2014

#40

  • package names opencv_apps? opencv_examples?
  • this package contains a lot of new message, show we create opencv_msgs that holds opencv basic data structure ? or ask other packages (geometry_msgs or others ) to add new messages?

here is how to run program, if you add _debug_view you can see debug view

rosrun opencv_apps lk_flow _debug_view:=true image:=/image_raw

@garaemon
Copy link
Contributor

great, +1

vrabaud
vrabaud reviewed Dec 31, 2014
View reviewed changes
opencv_apps/cfg/CamShift.cfg
# copyright notice, this list of conditions and the following
# disclaimer in the documentation and/or other materials provided
# with the distribution.
# * Neither the name of Willow Garage, Inc. nor the names of its
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi please make sure it's your name here and not Willow garage.

@vrabaud
Copy link
Contributor

vrabaud commented Dec 31, 2014

wow, that is a really nice contribution ! Fix the tiny remarks and I'll merge that. I'll also make sure it works with OpenCV3.

@k-okada
Copy link
Contributor Author

k-okada commented Jan 4, 2015

Ok , I fixed license and includes, which version of OpenCV3 are you using? opencv-3.0.0-beta https://github.com/Itseez/opencv/archive/3.0.0-beta.zip?

@vrabaud
Copy link
Contributor

vrabaud commented Jan 4, 2015

I still see Willow Garage in all license files. And for OpenCV3, no worries, this can wait. There is a package in indigo called OpenCV3 and it just requires some ifdef: 8216fb5

@vrabaud
Copy link
Contributor

vrabaud commented Jan 4, 2015

ok, merging as is, I will fix those details. Thx !

vrabaud added a commit that referenced this pull request Jan 4, 2015
@vrabaud
Merge pull request #56 from k-okada/opencv_apps
605f095 
add opencv_apps, proposed in #40
@vrabaud vrabaud merged commit 605f095 into ros-perception:indigo Jan 4, 2015
@k-okada
Copy link
Contributor Author

k-okada commented Jan 4, 2015

Oh, sorry I just updated,

◉ Kei Okada

On Sun, Jan 4, 2015 at 11:39 PM, Vincent Rabaud notifications@github.com
wrote:

Merged #56 #56.

—
Reply to this email directly or view it on GitHub
#56 (comment).

@k-okada
Copy link
Contributor Author

k-okada commented Jan 4, 2015

I removed all Willow Garage, https://github.com/k-okada/vision_opencv/tree/opencv_apps/opencv_apps,

@vrabaud
Copy link
Contributor

vrabaud commented Jan 4, 2015

ok, getting your fix in. Thx !

@vrabaud
Copy link
Contributor

vrabaud commented Jan 4, 2015

and the code compiles under OpenCV3: 89a933a

@vrabaud vrabaud mentioned this pull request Jan 4, 2015
Closed
@k-okada k-okada mentioned this pull request Dec 17, 2015
Open
@k-okada k-okada mentioned this pull request Jun 1, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@k-okada @garaemon @vrabaud