Fix all references to "MoveIt" to include exclamation mark e.g. "MoveIt!" #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also applies clang format on the |
|
Somehow you ran the wrong type of clang-format - it should not have caused this many changes. Can you remove the "apply clang format" commit and try again using the instructions here: http://moveit.ros.org/documentation/contributing/code/ Maybe you have the wrong version of clang-format? |
|
Yes I've noticed that |
mayman99
force-pushed
the
fix_references_to_moveit
branch
2 times, most recently
from
a31b489
to
b149204
Compare
davetcoleman
approved these changes
Aug 14, 2018
mcevoyandy
approved these changes
Aug 14, 2018
| structure describes that controller's state. */ | ||
| struct ControllerState | ||
| { | ||
| ControllerState() : active_(false), default_(false) | ||
| { | ||
| } | ||
|
|
||
| /** \brief A controller can be active or inactive. This means that MoveIt could activate the controller when needed, | ||
| /** \brief A controller can be active or inactive. This means that MoveIt! could activate the controller when | ||
| needed, |
| and de-activate controllers that overlap (control the same set of joints) */ | ||
| bool active_; | ||
|
|
||
| /** \brief It is often the case that multiple controllers could be used to execute a motion. Marking a controller as | ||
| default | ||
| makes MoveIt prefer this controller when multiple options are available. */ | ||
| makes MoveIt! prefer this controller when multiple options are available. */ |
|
Fixed text wrap 👍 @mcevoyandy |
mayman99
force-pushed
the
fix_references_to_moveit
branch
from
b149204
to
0f3229b
Compare
|
cherry-pick: #1030 |
rhaschke
pushed a commit
that referenced
this pull request
Aug 22, 2018
JafarAbdi
added a commit
to JafarAbdi/moveit
that referenced
this pull request
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix all references to "MoveIt" to include exclamation mark e.g. "MoveIt!".
Checklist