Benchmark planning pipelines instead of plugins only #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henningkayser
force-pushed
the
pr-benchmark-planning_pipelines
branch
2 times, most recently
from
11eb7de
to
20f5e75
Compare
davetcoleman
changed the base branch from
feature-benchmark-improvements
to
master
Can you make this PR now, to ensure it actually happens? |
davetcoleman
approved these changes
Jul 25, 2019
| @@ -259,6 +277,14 @@ def readBenchmarkLog(dbname, filenames): | |||
|
|
|||
| logfile.readline() | |||
| logfile.close() | |||
|
|
|||
| if addAllExperiments: | |||
henningkayser
force-pushed
the
pr-benchmark-planning_pipelines
branch
from
f6e6a99
to
00db147
Compare
rhaschke
pushed a commit
that referenced
this pull request
Aug 15, 2019
... instead of planning plugins only
henningkayser
added a commit
to PickNikRobotics/moveit
that referenced
this pull request
Nov 21, 2019
... instead of planning plugins only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1510 and #1530 this adds support for running benchmarks on full planning pipelines.
This only requires minor changes in the configuration, in particular specifying pipeline namespaces in the launch files and using this names instead of plugin identifiers inside the yaml files.
If approved, I will add appropriate changes for the tutorial.
Please review the last commit bc689be only. All other changes are included from #1510.