fixed REALTIME planned path trajectory playback #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for helping in improving MoveIt |
henningkayser
approved these changes
Oct 3, 2019
|
@henningkayser what problems are you seeing with loop animation enabled? I just ran a few simple tests and don't see any issues. The tool was able to loop the entire animation and was also able to pickup looping when starting from any point in the trajectory. If I know what to look for I might have some time to fix it. |
|
@MarqRazz actually, I expected the TrajectorySlider to have the same behavior as the MotionPlanning slider (syncing to the loop), which obviously is not the case. So nothing to fix here ;) |
|
Congrats on getting your first MoveIt pull request merged and improving open source robotics! |
henningkayser
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
Nov 21, 2019
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Mar 30, 2020
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Mar 31, 2020
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Mar 31, 2020
sjahr
pushed a commit
to sjahr/moveit
that referenced
this pull request
Jun 21, 2024
* Add new error types (moveit_msgs moveit#146) * Add default case * Small change to the default case Co-authored-by: Tyler Weaver <maybe@tylerjw.dev> Co-authored-by: Tyler Weaver <maybe@tylerjw.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the REALTIME mode to display the planned path the program would stop at the last or second to last waypoint and is unable to re-play the trajectory when using the trajectory slider plugin.
This pull request fixes the REALTIME playback mode to always finish playing the full trajectory and has the ability to properly pause and continue playback using the trajectory slider plugin.
Please let me know if you would like me to add any tests, features or changes.
Thanks,
-Marq