[AIST-QA]Fix possibile division-by-zero issues. #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correct the indication by the static analysis tool. - Added a safeguard and display warning.
- Correct the indication by the static analysis tool. - Added a safegurad that check scale value is zero or non-zero.
|
Thanks for helping in improving MoveIt and open source robotics! |
|
To fulfill the checklist requirement, I've reviewed this PR: #1804 and left a comment. |
felixvd
suggested changes
Dec 12, 2019
There was a problem hiding this comment.
I don't have objections about the benchmark, but the addition in ChompCost should be changed imo. Unintuitive/edge-case behavior like that should not be silent, it's too easy to create hard-to-find bugs down the line.
Also pinging @BryceStevenWilley because he'd be more familiar with this part of the code.
felixvd
approved these changes
Dec 13, 2019
rhaschke
approved these changes
Dec 13, 2019
|
Congrats on getting your first MoveIt pull request merged and improving open source robotics! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Local variables are used as denominator in
measure_ik_call_cost.cppandchomp_optimizer.cpp.These variables are initialized with zero and there are cases when they are used without changing value.
This fix adds checking the local variable against zero. (In
chomp_optimizer, the fix is applied to the functionChompCost::scale)This contribution is made by AIST ( https://www.aist.go.jp ) based on static code analysis with klocwork (Perforce Software).
Checklist