Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installs an empty plugin description xml file if bullet is not found #1898

Merged
merged 2 commits into from
Feb 19, 2020

Conversation

progtologist
Copy link
Contributor

Fair warning: This only fixes the install workspace, in the devel workspace if bullet was not found at compile you will still get errors from pluginlib.

Description

Added an "empty" pluginlib xml file to be installed in place of collision_detector_bullet_description.xml if bullet is not found at compile time.
Related PR: #1839

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@welcome
Copy link

welcome bot commented Feb 13, 2020

Thanks for helping in improving MoveIt and open source robotics!

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. Please consider the comment below.

@rhaschke rhaschke added the awaits 2nd review one maintainer approved this request label Feb 13, 2020
@codecov-io
Copy link

codecov-io commented Feb 13, 2020

Codecov Report

Merging #1898 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1898      +/-   ##
==========================================
+ Coverage   50.26%   50.27%   +<.01%     
==========================================
  Files         313      313              
  Lines       24624    24626       +2     
==========================================
+ Hits        12378    12381       +3     
+ Misses      12246    12245       -1
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 55.53% <0%> (+0.14%) ⬆️
...ccupancy_map_monitor/src/occupancy_map_monitor.cpp 30.61% <0%> (+0.47%) ⬆️
...ccupancy_map_monitor/src/occupancy_map_updater.cpp 9.09% <0%> (+4.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd85e7d...04135e8. Read the comment docs.

@j-petit
Copy link
Contributor

j-petit commented Feb 14, 2020

Looks good to me, thanks for fixing this!

@mlautman mlautman merged commit 193cbea into moveit:master Feb 19, 2020
@welcome
Copy link

welcome bot commented Feb 19, 2020

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits 2nd review one maintainer approved this request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants