Utilize setScaleDirty() and setPaddingDirty() to improve performance

[peci1]

Description

As requested in moveit/geometric_shapes#109 (comment).

I only found one candidate usage...

Checklist

• Required by CI: Code is auto formatted using clang-format
• Extend the tutorials / documentation reference
• Document API changes relevant to the user in the MIGRATION.md notes
• Create tests, which fail without this PR reference
• Include a screenshot if changing a GUI
• While waiting for someone to review your request, please help review another open pull request to support the maintainers

[peci1]

Could be optimized even more by backport of moveit/geometric_shapes#137 to melodic.

[v4hn]

backport in progress: moveit/geometric_shapes#142
Feel free to update the patch to make use of it.

[v4hn]

@peci1 we actually moved to depend on noetic-devel for geometric_shapes in master now, but the patch was also backported. Could you update this patch too, please?

[peci1]

The speedup has been implemented. I found two more places where it can be done.

[codecov-commenter]

Codecov Report

Merging #2038 into master will increase coverage by 0.00%.
The diff coverage is 77.77%.

@@           Coverage Diff           @@
##           master    #2038   +/-   ##
=======================================
  Coverage   57.79%   57.79%           
=======================================
  Files         328      328           
  Lines       25664    25665    +1     
=======================================
+ Hits        14833    14834    +1     
  Misses      10831    10831           

Impacted Files	Coverage Δ
...kinematic_constraints/src/kinematic_constraint.cpp	72.69% <50.00%> (-0.05%)	⬇️
moveit_core/distance_field/src/distance_field.cpp	26.02% <100.00%> (ø)
...eption/point_containment_filter/src/shape_mask.cpp	53.94% <100.00%> (+1.24%)	⬆️
...ma_kinematics_plugin/src/lma_kinematics_plugin.cpp	78.94% <0.00%> (-2.26%)	⬇️
...anning_scene_monitor/src/current_state_monitor.cpp	52.82% <0.00%> (+1.53%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 736219d...804192c. Read the comment docs.

[v4hn]

Looks good to me. Thanks as many times before @peci1 😃