Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a parameter switch in moveit_cpp loading #2187

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Fix a parameter switch in moveit_cpp loading #2187

merged 1 commit into from
Jul 3, 2020

Conversation

AndyZe
Copy link
Member

@AndyZe AndyZe commented Jul 3, 2020

A simple bug fix. Caught by @mechwiz

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, thanks for fixing!

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #2187 into master will increase coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2187      +/-   ##
==========================================
+ Coverage   57.61%   57.93%   +0.32%     
==========================================
  Files         327      327              
  Lines       24923    25677     +754     
==========================================
+ Hits        14359    14876     +517     
- Misses      10564    10801     +237     
Impacted Files Coverage Δ
...cpp/include/moveit/moveit_cpp/planning_component.h 100.00% <100.00%> (ø)
...eit/planning_scene_monitor/current_state_monitor.h 50.00% <0.00%> (-50.00%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 70.10% <0.00%> (-29.90%) ⬇️
.../ompl_interface/src/detail/constrained_sampler.cpp 46.15% <0.00%> (-17.95%) ⬇️
...g_scene_interface/src/planning_scene_interface.cpp 51.51% <0.00%> (-3.28%) ⬇️
...meterization/work_space/pose_model_state_space.cpp 82.31% <0.00%> (-0.69%) ⬇️
...it/planning_scene_monitor/planning_scene_monitor.h 91.30% <0.00%> (+0.39%) ⬆️
...ipulation/pick_place/src/manipulation_pipeline.cpp 77.35% <0.00%> (+0.94%) ⬆️
...anning_scene_monitor/src/current_state_monitor.cpp 52.82% <0.00%> (+1.53%) ⬆️
moveit_ros/moveit_servo/src/servo_calcs.cpp 73.70% <0.00%> (+3.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a15551f...2deba12. Read the comment docs.

@v4hn v4hn merged commit 73fa9ea into moveit:master Jul 3, 2020
@v4hn
Copy link
Contributor

v4hn commented Jul 3, 2020

This definitely should be part of melodic-devel before the release.

v4hn pushed a commit to v4hn/moveit that referenced this pull request Jul 3, 2020
@v4hn v4hn mentioned this pull request Jul 4, 2020
@AndyZe AndyZe deleted the andyz/moveit_cpp_loading branch September 18, 2020 13:33
sjahr pushed a commit to sjahr/moveit that referenced this pull request Jun 21, 2024
Co-authored-by: Ezra Brooks <ezra@brooks.cx>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants