[maint] cleanup includes #2351
[maint] cleanup includes #2351
Conversation
rhaschke
requested review from
felixvd,
henningkayser,
mikeferguson,
tylerjw and
v4hn
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2351 +/- ##
=======================================
Coverage 56.63% 56.63%
=======================================
Files 281 281
Lines 25457 25457
=======================================
Hits 14415 14415
Misses 11042 11042
Continue to review full report at Codecov.
|
rhaschke
force-pushed
the
cleanup-includes
branch
2 times, most recently
from
b2b4ade
to
302b0d7
Compare
| vspacer->setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Expanding); | ||
| layout->addWidget(vspacer); | ||
| // Vertical Spacer | ||
| layout->addItem(new QSpacerItem(20, 20, QSizePolicy::Minimum, QSizePolicy::Expanding)); |
There was a problem hiding this comment.
I know this is probably a normal QT style but all these new statements make me think it'd be easy to leak memory. I manually read through this function though and it doesn't look like we are here.
There was a problem hiding this comment.
Qt has its own memory management, releasing all children together with a parent object.
Adding items here to the layout adds the spacer as a child to the layout.
This is more elegantly handled by system includes now.
rhaschke
force-pushed
the
cleanup-includes
branch
from
302b0d7
to
c16e27d
Compare
|
I will handle the conflict tomorrow. |
* *Changed boost namespace to std *Need to compare function implementations *Find an equivalent implementation for variate_generator * calling Distribution(Engine) directly * cleanup * Seed mersenne twister variable with random device * Updated with rsl random library
This PR uses forward declarations in MSA, wherever possible and moves most includes into .cpp files.
Additionally, this reverts 7b86d4d as we silent external warnings via system includes now.
Note, that this builds on top of #2349!