-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add API for passing RNG to setToRandomPositionsNearBy #2799
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2799 +/- ##
==========================================
- Coverage 60.87% 60.44% -0.42%
==========================================
Files 366 366
Lines 31705 31677 -28
==========================================
- Hits 19296 19144 -152
- Misses 12409 12533 +124
Continue to review full report at Codecov.
|
See #2802 for CI failure |
741e194
to
b5f775e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable. Do you plan on updating the tests to make them more consistent by using a fixed seed and a specific RNG?
Please rebase so we can merge this. I tried updating it for you but the checkbox to let me push wasn't checked. |
Nice idea. Make a "good first issue" post out of it! |
b5f775e
to
cb4ca38
Compare
Yea I can put adding a test on my TODO list but no guarantees, it would be good to make an issue for it then I can watch it |
|
…re consistent as asked in issue moveit#2851
Description
add API for passing RNG to setToRandomPositionsNearBy
Checklist