Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove obsolete distutils.core #3103

Merged
merged 1 commit into from Mar 29, 2022

Conversation

v4hn
Copy link
Member

@v4hn v4hn commented Mar 28, 2022

Addresses this deprecation warning in python 3.10.

DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives

Addresses this deprecation warning in python 3.10.

> DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
@v4hn
Copy link
Member Author

v4hn commented Mar 28, 2022

What's going on here @gavanderhoorn @rhaschke @JafarAbdi ?

Traceback (most recent call last):
File "/home/runner/.cache/pre-commit/repo99i8qo0i/py_env-python3/bin/black", line 8, in
sys.exit(patched_main())
File "/home/runner/.cache/pre-commit/repo99i8qo0i/py_env-python3/lib/python3.10/site-packages/black/init.py", line 6606, in patched_main
patch_click()
File "/home/runner/.cache/pre-commit/repo99i8qo0i/py_env-python3/lib/python3.10/site-packages/black/init.py", line 6595, in patch_click
from click import _unicodefun # type: ignore
ImportError: cannot import name '_unicodefun' from 'click' (/home/runner/.cache/pre-commit/repo99i8qo0i/py_env-python3/lib/python3.10/site-packages/click/init.py)

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #3103 (4a5fd61) into master (72d9192) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3103      +/-   ##
==========================================
+ Coverage   61.63%   61.65%   +0.02%     
==========================================
  Files         376      376              
  Lines       33275    33275              
==========================================
+ Hits        20507    20513       +6     
+ Misses      12768    12762       -6     
Impacted Files Coverage Δ
...raint_samplers/src/default_constraint_samplers.cpp 79.60% <0.00%> (-0.28%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 52.28% <0.00%> (-0.07%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 66.88% <0.00%> (+0.13%) ⬆️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 78.28% <0.00%> (+0.38%) ⬆️
...on/pick_place/src/approach_and_translate_stage.cpp 74.69% <0.00%> (+0.64%) ⬆️
...ipulation/pick_place/src/manipulation_pipeline.cpp 74.39% <0.00%> (+0.83%) ⬆️
...eit_ros/manipulation/pick_place/src/pick_place.cpp 92.39% <0.00%> (+3.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72d9192...4a5fd61. Read the comment docs.

@rhaschke rhaschke merged commit 08331b4 into ros-planning:master Mar 29, 2022
@stephanie-eng
Copy link
Contributor

What's going on here @gavanderhoorn @rhaschke @JafarAbdi ?

Traceback (most recent call last):
File "/home/runner/.cache/pre-commit/repo99i8qo0i/py_env-python3/bin/black", line 8, in
sys.exit(patched_main())
File "/home/runner/.cache/pre-commit/repo99i8qo0i/py_env-python3/lib/python3.10/site-packages/black/init.py", line 6606, in patched_main
patch_click()
File "/home/runner/.cache/pre-commit/repo99i8qo0i/py_env-python3/lib/python3.10/site-packages/black/init.py", line 6595, in patch_click
from click import _unicodefun # type: ignore
ImportError: cannot import name '_unicodefun' from 'click' (/home/runner/.cache/pre-commit/repo99i8qo0i/py_env-python3/lib/python3.10/site-packages/click/init.py)

There's an issue with click that broke black, a newer version of black should fix this - I've made a PR for this here:
#3105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants