New debug console colors YELLOW PURPLE GRAY #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davetcoleman
changed the title
davetcoleman
force-pushed
the
kinetic-colors
branch
from
2d36368
to
d0ab602
Compare
|
The problem with hard-coding these numbers is that they might vary depending on the terminal / configuration. - This is also pointed out in the page you linked to. Anyway, thanks for the cleanup. Of course it makes sense to retain the old BROWN constant. |
v4hn
pushed a commit
that referenced
this pull request
Aug 30, 2017
|
picked to indigo |
JafarAbdi
pushed a commit
to JafarAbdi/moveit
that referenced
this pull request
Mar 24, 2022
Co-authored-by: Tyler Weaver <tyler@picknik.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds purple, gray, and yellow, although yellow shadows the misnamed brown color in moveit.
I added a comment to show they are the same value, and ordered the colors per @v4hn
Replaces #601