Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added capabilties as arg to move_group.launch #998

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

agutenkunst
Copy link
Contributor

Enable the user to pass capabilities that should be loaded / inhibited
as arg to move_group.launch

Description

I ran into the issue because I wanted to load capabilities into the move_group from another package.
Without this PR I would need to duplicate the move_group.launch file.
Passing it as an arg is the same way the other args are handled.

Enable the user to pass capabilities that should be loaded / inhibited
as arg to move_group.launch
@v4hn
Copy link
Contributor

v4hn commented Jul 25, 2018

I do not really see the necessity for this.
You can always set

<rosparam name="move_group/capabilities">
my_awesome_capability
</rosparam>

The move_group namespace is pretty much enforced in MoveIt, so there is not even a problem with node renaming.

Wouldn't you agree?

@davetcoleman
Copy link
Member

interesting workaround @v4hn

Copy link
Contributor

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this again, there is also no harm in having the arguments there. Maybe it makes things a bit clearer in custom launch includes...
I approve as is.

@rhaschke rhaschke merged commit e6f65c4 into moveit:kinetic-devel Sep 4, 2018
rhaschke pushed a commit that referenced this pull request Sep 6, 2018
Enable the user to pass capabilities that should be loaded / inhibited as arg to move_group.launch
pull bot pushed a commit to shadow-robot/moveit that referenced this pull request Sep 3, 2020
Enable the user to pass capabilities that should be loaded / inhibited as arg to move_group.launch
JafarAbdi pushed a commit to JafarAbdi/moveit that referenced this pull request Mar 24, 2022
* Delete profiler and evaluator tools

Signed-off-by: Tyler Weaver <tylerjw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants