Fix the added path index vector merge in PlanningRequestAdapterChain #3464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## noetic-devel #3464 +/- ##
================================================
- Coverage 61.83% 61.81% -0.01%
================================================
Files 385 385
Lines 34064 34090 +26
================================================
+ Hits 21059 21071 +12
- Misses 13005 13019 +14
☔ View full report in Codecov by Sentry. |
Hugal31
force-pushed
the
fix/added-path-index-merge
branch
from
ff26adc
to
d85a462
Compare
When merging the `added_path_index` for the different planning request adapters, the `PlanningRequestAdapterChain` was adding them in the wrong order, causing wrong incrementation of the indices. Closes moveit#3463.
Hugal31
force-pushed
the
fix/added-path-index-merge
branch
from
d85a462
to
3cec193
Compare
rhaschke
approved these changes
Sep 25, 2023
This was referenced Sep 28, 2023
rhaschke
pushed a commit
to rhaschke/moveit2
that referenced
this pull request
Oct 16, 2023
cherry-pick of moveit/moveit#3464
rhaschke
pushed a commit
to rhaschke/moveit2
that referenced
this pull request
Oct 17, 2023
cherry-pick of moveit/moveit#3464
sjahr
pushed a commit
to moveit/moveit2
that referenced
this pull request
Oct 18, 2023
* Port unit test cherry-pick of moveit/moveit#3464 * Increment added_path_index in callAdapter Doesn't work because previous=0 for all recursively called functions. * Pass individual add_path_index vectors to callAdapter --------- Co-authored-by: Hugal31 <hla@lescompanions.com>
m-elwin
pushed a commit
to m-elwin/moveit2
that referenced
this pull request
Dec 4, 2023
* Port unit test cherry-pick of moveit/moveit#3464 * Increment added_path_index in callAdapter Doesn't work because previous=0 for all recursively called functions. * Pass individual add_path_index vectors to callAdapter --------- Co-authored-by: Hugal31 <hla@lescompanions.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When merging the
added_path_indexfor the different planning request adapters, thePlanningRequestAdapterChainwas adding them in the wrong order, causing wrong incrementation of the indices.Closes #3463.
Checklist