Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified code comment style #1053

Merged
merged 12 commits into from
Aug 10, 2022
Merged

Unified code comment style #1053

merged 12 commits into from
Aug 10, 2022

Conversation

michael-marron
Copy link
Contributor

@michael-marron michael-marron commented Feb 1, 2022

Changed the comment style from /**/ to //
Issue:
#852

Description

Please explain the changes you made, including a reference to the related issue if applicable

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Changed the comment style from /**/ to //
Changed comment from /**/ to //
Changed comment from /**/ to //
Changed comment from /**/ to //
Changed comment from /**/ to //
Changed comment from /**/ to //
Changed comment from /**/ to //
@vatanaksoytezer
Copy link
Contributor

@michael-marron thank you for the PR. Can you run pre-commit so formatting errors are gone, https://github.com/ros-planning/moveit2_tutorials#formatting-and-style might help get you running pretty quick.

@henningkayser henningkayser changed the title Update test.cpp Unified code comment style Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1053 (f086595) into main (cf87738) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
+ Coverage   51.11%   51.12%   +0.01%     
==========================================
  Files         380      380              
  Lines       31737    31737              
==========================================
+ Hits        16218    16221       +3     
+ Misses      15519    15516       -3     
Impacted Files Coverage Δ
moveit_core/kinematic_constraints/src/utils.cpp 24.53% <ø> (ø)
moveit_core/planning_scene/src/planning_scene.cpp 52.53% <ø> (ø)
moveit_core/robot_state/src/robot_state.cpp 47.44% <ø> (ø)
moveit_core/utils/src/message_checks.cpp 83.34% <ø> (ø)
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 76.43% <0.00%> (+1.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@henningkayser henningkayser merged commit 1d67b51 into moveit:main Aug 10, 2022
@tylerjw tylerjw added the backport-humble Mergify label that triggers a PR backport to Humble label Oct 28, 2022
mergify bot pushed a commit that referenced this pull request Oct 28, 2022
* Changes the comment style from /**/ to //

Co-authored-by: JafarAbdi <cafer.abdi@gmail.com>
Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
(cherry picked from commit 1d67b51)
tylerjw pushed a commit that referenced this pull request Oct 28, 2022
* Changes the comment style from /**/ to //

Co-authored-by: JafarAbdi <cafer.abdi@gmail.com>
Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
(cherry picked from commit 1d67b51)

Co-authored-by: Michael Marron <62182318+michael-marron@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants