Port sensor_manager of moveit_core to ROS 2.0 #11
Conversation
| @@ -1 +1 @@ | |||
| install(DIRECTORY include/ DESTINATION ${CATKIN_GLOBAL_INCLUDE_DESTINATION}) | |||
| install(DIRECTORY include/ DESTINATION include) | |||
There was a problem hiding this comment.
@mlautman is this best practice? should we ask dirk?
There was a problem hiding this comment.
There was a problem hiding this comment.
As stated somewhere else, I believe GNUInstallDirs is the better approach here - from a maintainer's point of few at least.
@dirk-thomas I believe you were involved with the migration instructions, right?
Did you know about that cmake module or did you deliberately ignore it?
The only possible shortcoming I can see is that you might end up with lib<arch> folders instead of lib depending on the context
There was a problem hiding this comment.
Using GNUInstallDirs or not is pretty much orthogonal to the migration instructions. You can either use it or not - in ROS 1 as well as in ROS 2 packages.
There was a problem hiding this comment.
It sounds like switching to GNUInstallDirs is outside the scope of a first-pass moveit port to ROS2, and @vmayoral 's approach is good
| #include <moveit_msgs/RobotTrajectory.h> | ||
| #include <geometry_msgs/PointStamped.h> | ||
| #include <moveit_msgs/msg/robot_trajectory.hpp> | ||
| #include <geometry_msgs/msg/point_stamped.hpp> |
There was a problem hiding this comment.
Wow, being rather ignorant of the current state of ROS2, I really wonder what should be the beautiful upside of changing includes like this, apart from making huge code-bases incompatible...
There was a problem hiding this comment.
IIRC, the rational is that this way, it's possible to have services, actions and msgs that have the same name (but I'm not 100% certain).
There was a problem hiding this comment.
^ that is correct. For example in ROS1 we had the standard of adding "Action" at the end of every action message type to avoid conflicts in messages or services, but it was decided (I have no opinion) to enforce this more rigorously through folders and namespaces
* working move_group_interface tutorial * splitting out prerequisites * updating images, video link, and a goal pose * adding author * fixing second youtube link * removing second video link
No description provided.