Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manipulation from moveit_ros #1177

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

stephanie-eng
Copy link
Contributor

Description

Remove manipulation package as per #1038

@stephanie-eng stephanie-eng marked this pull request as draft April 12, 2022 14:58
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #1177 (29fa6a8) into main (4a16b05) will decrease coverage by 0.37%.
The diff coverage is n/a.

❗ Current head 29fa6a8 differs from pull request most recent head 5bb2010. Consider uploading reports for the commit 5bb2010 to get more accurate results

@@            Coverage Diff             @@
##             main    #1177      +/-   ##
==========================================
- Coverage   61.56%   61.20%   -0.36%     
==========================================
  Files         274      274              
  Lines       24965    24825     -140     
==========================================
- Hits        15368    15192     -176     
- Misses       9597     9633      +36     
Impacted Files Coverage Δ
...e/src/parameterization/model_based_state_space.cpp 68.33% <0.00%> (-18.01%) ⬇️
...terface/parameterization/model_based_state_space.h 87.18% <0.00%> (-10.25%) ⬇️
moveit_core/planning_scene/src/planning_scene.cpp 48.84% <0.00%> (-3.68%) ⬇️
moveit_core/robot_model/src/joint_model_group.cpp 61.92% <0.00%> (-1.96%) ⬇️
...src/bullet_integration/bullet_cast_bvh_manager.cpp 51.43% <0.00%> (-1.42%) ⬇️
...tance_field/src/collision_distance_field_types.cpp 34.79% <0.00%> (-0.86%) ⬇️
...mpl_interface/src/model_based_planning_context.cpp 51.21% <0.00%> (-0.29%) ⬇️
.../src/bullet_integration/contact_checker_common.cpp 84.51% <0.00%> (-0.21%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 47.29% <0.00%> (-0.15%) ⬇️
...raint_samplers/src/default_constraint_samplers.cpp 71.75% <0.00%> (-0.07%) ⬇️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a16b05...5bb2010. Read the comment docs.

@mergify
Copy link

mergify bot commented Apr 12, 2022

This pull request is in conflict. Could you fix it @stephanie-eng?

@stephanie-eng stephanie-eng marked this pull request as ready for review April 22, 2022 17:07
@AndyZe
Copy link
Member

AndyZe commented Apr 23, 2022

If you do some grepping, it looks like there are still some references to moveit_ros_manipulation to be removed. For example,

move_group/src/move_group.cpp:    // TODO (ddengster) : wait for port for moveit_ros_manipulation package
planning_interface/move_group_interface/src/move_group_interface.cpp:// TODO(JafarAbdi): Enable once moveit_ros_manipulation is ported
planning_interface/move_group_interface/src/move_group_interface.cpp:    // TODO(JafarAbdi): Enable once moveit_ros_manipulation is ported
planning_interface/CMakeLists.txt:# find_package(moveit_ros_manipulation REQUIRED)
planning_interface/CMakeLists.txt:#  moveit_ros_manipulation
planning_interface/package.xml:  <!-- TODO(JafarAbdi): uncomment after porting moveit_ros_manipulation -->
planning_interface/package.xml:  <!--depend>moveit_ros_manipulation</depend-->

Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more reference to remove:

moveit_ros/planning_interface/CMakeLists.txt:# find_package(moveit_ros_manipulation REQUIRED)

Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving provided the last reference to moveit_ros_manipulation gets removed 👍

@stephanie-eng stephanie-eng force-pushed the seng/remove_manipulation branch 2 times, most recently from fe3593e to 7e38547 Compare April 25, 2022 16:09
@mergify
Copy link

mergify bot commented May 10, 2022

This pull request is in conflict. Could you fix it @stephanie-eng?

@mergify
Copy link

mergify bot commented Jun 13, 2022

This pull request is in conflict. Could you fix it @stephanie-eng?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants