Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSA] Three small edits #1203

Merged
merged 3 commits into from
May 2, 2022
Merged

Conversation

DLu
Copy link
Contributor

@DLu DLu commented Apr 29, 2022

Description

Three small edits to get the feature/msa

  • Fixes XML rendering in README.md
  • Removes a TODO for functionality that has not been needed in the ROS 2 port.
  • Removes a duplicated header inclusion.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@mergify
Copy link

mergify bot commented Apr 29, 2022

Please target the main branch for development, we will backport the changes to feature/msa for you if approved and if they don't break API.

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #1203 (b0c6d06) into feature/msa (9a8e005) will decrease coverage by 1.24%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           feature/msa    #1203      +/-   ##
===============================================
- Coverage        61.02%   59.78%   -1.23%     
===============================================
  Files              275      275              
  Lines            23761    23761              
===============================================
- Hits             14498    14204     -294     
- Misses            9263     9557     +294     
Impacted Files Coverage Δ
.../moveit_servo/include/moveit_servo/pose_tracking.h 0.00% <0.00%> (-100.00%) ⬇️
...servo/include/moveit_servo/make_shared_from_pool.h 0.00% <0.00%> (-100.00%) ⬇️
moveit_ros/moveit_servo/src/pose_tracking.cpp 0.00% <0.00%> (-77.00%) ⬇️
...eit/planning_scene_monitor/current_state_monitor.h 77.78% <0.00%> (-22.22%) ⬇️
...anning_scene_monitor/src/current_state_monitor.cpp 54.15% <0.00%> (-21.83%) ⬇️
moveit_ros/moveit_servo/src/servo.cpp 58.63% <0.00%> (-13.79%) ⬇️
moveit_ros/moveit_servo/src/collision_check.cpp 78.69% <0.00%> (-6.55%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 40.74% <0.00%> (-6.37%) ⬇️
...or/src/current_state_monitor_middleware_handle.cpp 82.36% <0.00%> (-5.88%) ⬇️
moveit_ros/moveit_servo/src/servo_calcs.cpp 65.67% <0.00%> (-2.47%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8e005...b0c6d06. Read the comment docs.

@vatanaksoytezer
Copy link
Contributor

@DLu can you fix the formatting?

@DLu DLu closed this May 1, 2022
@DLu DLu reopened this May 1, 2022
Copy link
Contributor

@JafarAbdi JafarAbdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last commit fixes the black formatter error, the other one looks to be a flaky test which is unrelated to this PR

@vatanaksoytezer vatanaksoytezer merged commit 365ce38 into moveit:feature/msa May 2, 2022
@DLu DLu deleted the minor_msa_tweaks branch May 2, 2022 01:39
DLu added a commit to DLu/moveit2 that referenced this pull request May 19, 2022
* Three small edits

* Update .pre-commit-config.yaml

* Run pre-commit

Co-authored-by: Jafar <cafer.abdi@gmail.com>
vatanaksoytezer pushed a commit that referenced this pull request May 25, 2022
* Three small edits

* Update .pre-commit-config.yaml

* Run pre-commit

Co-authored-by: Jafar <cafer.abdi@gmail.com>
vatanaksoytezer pushed a commit that referenced this pull request May 31, 2022
* Three small edits

* Update .pre-commit-config.yaml

* Run pre-commit

Co-authored-by: Jafar <cafer.abdi@gmail.com>
vatanaksoytezer pushed a commit that referenced this pull request May 31, 2022
* Three small edits

* Update .pre-commit-config.yaml

* Run pre-commit

Co-authored-by: Jafar <cafer.abdi@gmail.com>
DLu added a commit to DLu/moveit2 that referenced this pull request Jun 13, 2022
* Three small edits

* Update .pre-commit-config.yaml

* Run pre-commit

Co-authored-by: Jafar <cafer.abdi@gmail.com>
DLu added a commit to DLu/moveit2 that referenced this pull request Jun 13, 2022
* Three small edits

* Update .pre-commit-config.yaml

* Run pre-commit

Co-authored-by: Jafar <cafer.abdi@gmail.com>
vatanaksoytezer pushed a commit that referenced this pull request Jun 14, 2022
* Three small edits

* Update .pre-commit-config.yaml

* Run pre-commit

Co-authored-by: Jafar <cafer.abdi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants