Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move_group_interface: No need to spin after publishing #1250

Merged
merged 1 commit into from
May 18, 2022

Conversation

JafarAbdi
Copy link
Contributor

@JafarAbdi JafarAbdi commented May 16, 2022

Description

Publishing doesn't require spinning, this is sometimes causing an exception Node '/move_group_interface_node' has already been added to an executor

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1250 (ade6ee9) into main (59a1307) will increase coverage by 1.28%.
The diff coverage is 77.64%.

@@            Coverage Diff             @@
##             main    #1250      +/-   ##
==========================================
+ Coverage   60.16%   61.44%   +1.28%     
==========================================
  Files         274      274              
  Lines       24830    24936     +106     
==========================================
+ Hits        14937    15319     +382     
+ Misses       9893     9617     -276     
Impacted Files Coverage Δ
...llision_detection/src/collision_octomap_filter.cpp 0.00% <0.00%> (ø)
.../collision_detection_fcl/src/collision_env_fcl.cpp 91.52% <ø> (ø)
...ory_processing/iterative_spline_parameterization.h 100.00% <ø> (ø)
...ctory_processing/iterative_time_parameterization.h 100.00% <ø> (ø)
...ry_processing/time_optimal_trajectory_generation.h 100.00% <ø> (ø)
...veit/trajectory_processing/time_parameterization.h 100.00% <ø> (ø)
...ocessing/src/iterative_spline_parameterization.cpp 84.46% <0.00%> (-1.07%) ⬇️
...processing/src/iterative_time_parameterization.cpp 91.99% <0.00%> (-1.32%) ⬇️
...ccupancy_map_monitor/src/occupancy_map_monitor.cpp 20.13% <ø> (ø)
...ics_plugin_loader/src/kinematics_plugin_loader.cpp 69.75% <ø> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d482c1d...ade6ee9. Read the comment docs.

@JafarAbdi JafarAbdi merged commit 5a39a7f into moveit:main May 18, 2022
@JafarAbdi JafarAbdi deleted the pr-fix_spin branch May 18, 2022 15:59
@henningkayser henningkayser added the backport-galactic Mergify label that triggers a PR backport to Galactic label Aug 10, 2022
mergify bot pushed a commit that referenced this pull request Aug 10, 2022
henningkayser pushed a commit that referenced this pull request Aug 10, 2022
… (#1500)

(cherry picked from commit 5a39a7f)

Co-authored-by: Jafar <cafer.abdi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-galactic Mergify label that triggers a PR backport to Galactic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants