Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed 'return false' in plan, move and execute such that MoveItErrorCode is returned #1266

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Changed 'return false' in plan, move and execute such that MoveItErrorCode is returned #1266

merged 1 commit into from
Jul 29, 2022

Conversation

tbastiaens-riwo
Copy link
Contributor

Description

Provided a fix for issue #1239.

@mergify
Copy link

mergify bot commented May 20, 2022

Please target the main branch for development, we will backport the changes to foxy for you if approved and if they don't break API.

@tbastiaens-riwo tbastiaens-riwo mentioned this pull request May 20, 2022
Closed
@codecov
Copy link

codecov bot commented May 22, 2022 •
edited
Loading

Codecov Report

Merging #1266 (ae183af) into main (ed7c6c9) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1266      +/-   ##
==========================================
- Coverage   50.92%   50.90%   -0.02%     
==========================================
  Files         381      381              
  Lines       31786    31786              
==========================================
- Hits        16184    16176       -8     
- Misses      15602    15610       +8
Impacted Files Coverage Δ
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 75.36% <0.00%> (-1.07%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 45.29% <0.00%> (-0.43%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 47.37% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed7c6c9...ae183af. Read the comment docs.

@henningkayser henningkayser changed the base branch from foxy to main June 2, 2022 15:44
@henningkayser henningkayser changed the base branch from main to foxy June 2, 2022 15:44
@henningkayser henningkayser changed the base branch from foxy to main June 2, 2022 15:46
@henningkayser henningkayser added backport-foxy Mergify label that triggers a PR backport to Foxy backport-galactic Mergify label that triggers a PR backport to Galactic backport-humble Mergify label that triggers a PR backport to Humble labels Jun 2, 2022
@tylerjw
Copy link
Member

tylerjw commented Jun 6, 2022

This is failing to build with this error:

could not convert ‘code’ from ‘rclcpp_action::ResultCode’ to ‘moveit::core::MoveItErrorCode’

@AndyZe
Copy link
Member

AndyZe commented Jun 6, 2022

Yeah, I screwed it up. @tbastiaens-riwo can you revert the last commit with git reset --hard HEAD~? Then force-push it. Sorry.

@mergify
Copy link

mergify bot commented Jun 8, 2022

This pull request is in conflict. Could you fix it @tbastiaens-riwo?

@vatanaksoytezer vatanaksoytezer merged commit 59ba941 into moveit:main Jul 29, 2022
mergify bot pushed a commit that referenced this pull request Jul 29, 2022
@tbastiaens-riwo @mergify
Changed 'return false' in plan, move and execute such that MoveItErro…
a1f7e88 
…rCode is returned (#1266)

(cherry picked from commit 59ba941)
@mergify mergify bot mentioned this pull request Jul 29, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jul 29, 2022
@tbastiaens-riwo @mergify
Changed 'return false' in plan, move and execute such that MoveItErro…
cb2d41b 
…rCode is returned (#1266)

(cherry picked from commit 59ba941)
@mergify mergify bot mentioned this pull request Jul 29, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jul 29, 2022
@tbastiaens-riwo @mergify
Changed 'return false' in plan, move and execute such that MoveItErro…
aac6795 
…rCode is returned (#1266)

(cherry picked from commit 59ba941)
@mergify mergify bot mentioned this pull request Jul 29, 2022
Merged
vatanaksoytezer pushed a commit that referenced this pull request Aug 9, 2022
@mergify
Changed 'return false' in plan, move and execute such that MoveItErro…
cd7c94c 
…rCode is returned (#1266) (#1459)
henningkayser pushed a commit that referenced this pull request Aug 10, 2022
@tbastiaens-riwo @henningkayser
Changed 'return false' in plan, move and execute such that MoveItErro…
2a8dfaa 
…rCode is returned (#1266)

(cherry picked from commit 59ba941)
henningkayser pushed a commit that referenced this pull request Aug 10, 2022
@mergify @tbastiaens-riwo
Changed 'return false' in plan, move and execute such that MoveItErro…
c643792 
…rCode is returned (backport #1266) (#1458)

(cherry picked from commit 59ba941)

Co-authored-by: tbastiaens-riwo <105370144+tbastiaens-riwo@users.noreply.github.com>
vatanaksoytezer pushed a commit that referenced this pull request Aug 10, 2022
@mergify
Changed 'return false' in plan, move and execute such that MoveItErro…
7dd0434 
…rCode is returned (#1266) (#1460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyZe AndyZe AndyZe approved these changes

@tylerjw tylerjw tylerjw approved these changes

@henningkayser henningkayser henningkayser approved these changes

@vatanaksoytezer vatanaksoytezer vatanaksoytezer approved these changes

Assignees
No one assigned
Labels
backport-foxy Mergify label that triggers a PR backport to Foxy backport-galactic Mergify label that triggers a PR backport to Galactic backport-humble Mergify label that triggers a PR backport to Humble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tbastiaens-riwo @tylerjw @AndyZe @henningkayser @vatanaksoytezer