Fix Callback execution in MGI #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henningkayser
added
WMD22
backport-galactic
Codecov Report
@@ Coverage Diff @@
## main #1305 +/- ##
==========================================
- Coverage 50.92% 50.90% -0.02%
==========================================
Files 381 381
Lines 31786 31786
==========================================
- Hits 16184 16176 -8
- Misses 15602 15610 +8
Continue to review full report at Codecov.
|
tylerjw
approved these changes
Jul 29, 2022
The initial implementation with the private node allowed for concurrent spinning of the same node, producing runtime exceptions. This change removes the need for a private node by letting MGI manage its own CallbackGroup and Executor thread.
tylerjw
force-pushed
the
pr/fix_mgi_callback_execution
branch
from
24646d8
to
e12b334
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jul 29, 2022
The initial implementation with the private node allowed for concurrent spinning of the same node, producing runtime exceptions. This change removes the need for a private node by letting MGI manage its own CallbackGroup and Executor thread. (cherry picked from commit 042186a)
mergify bot
pushed a commit
that referenced
this pull request
Jul 29, 2022
The initial implementation with the private node allowed for concurrent spinning of the same node, producing runtime exceptions. This change removes the need for a private node by letting MGI manage its own CallbackGroup and Executor thread. (cherry picked from commit 042186a)
henningkayser
added a commit
that referenced
this pull request
Aug 9, 2022
The initial implementation with the private node allowed for concurrent spinning of the same node, producing runtime exceptions. This change removes the need for a private node by letting MGI manage its own CallbackGroup and Executor thread. (cherry picked from commit 042186a)
henningkayser
added a commit
that referenced
this pull request
Aug 10, 2022
The initial implementation with the private node allowed for concurrent spinning of the same node, producing runtime exceptions. This change removes the need for a private node by letting MGI manage its own CallbackGroup and Executor thread. (cherry picked from commit 042186a) Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
henningkayser
added a commit
that referenced
this pull request
Aug 10, 2022
The initial implementation with the private node allowed for concurrent spinning of the same node, producing runtime exceptions. This change removes the need for a private node by letting MGI manage its own CallbackGroup and Executor thread. (cherry picked from commit 042186a)
henningkayser
added a commit
that referenced
this pull request
Aug 10, 2022
The initial implementation with the private node allowed for concurrent spinning of the same node, producing runtime exceptions. This change removes the need for a private node by letting MGI manage its own CallbackGroup and Executor thread. (cherry picked from commit 042186a) Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation with the private node allowed for concurrent spinning of the same node, producing runtime exceptions. This change removes the need for a private node by letting MGI manage its own CallbackGroup and Executor thread.
Fixes #1302