Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure moveit warehouse package #1551

Merged
merged 4 commits into from
Sep 13, 2022

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Sep 5, 2022

Description

Remove manifest.xml and Makefile and restructure package from

warehouse
├── warehouse
│      ├── include 
│      └── src
├── CMakeLists.txt
...

to

warehouse
├── include 
├── src
├── CMakeLists.txt
...

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #1551 (820621b) into main (ed197cc) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1551      +/-   ##
==========================================
- Coverage   51.12%   51.10%   -0.02%     
==========================================
  Files         380      380              
  Lines       31802    31802              
==========================================
- Hits        16256    16249       -7     
- Misses      15546    15553       +7     
Impacted Files Coverage Δ
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 75.36% <0.00%> (-1.07%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 45.29% <0.00%> (-0.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cleanup looks very reasonable, thank you!

moveit_ros/warehouse/CMakeLists.txt Show resolved Hide resolved
@mergify
Copy link

mergify bot commented Sep 7, 2022

This pull request is in conflict. Could you fix it @sjahr?

@sjahr sjahr force-pushed the pr-update_moveit_warehouse_package branch from 50d3b85 to ec07a9e Compare September 7, 2022 08:25
@sjahr
Copy link
Contributor Author

sjahr commented Sep 8, 2022

@henningkayser can you re-trigger CI, the servo tests failed

@sjahr sjahr mentioned this pull request Sep 8, 2022
6 tasks
@henningkayser henningkayser merged commit 8fddbda into moveit:main Sep 13, 2022
@tylerjw tylerjw added the backport-humble Mergify label that triggers a PR backport to Humble label Oct 28, 2022
mergify bot pushed a commit that referenced this pull request Oct 28, 2022
* Restructure warhouse package to match other packages, remove manifest.xml
* Cleanup CMakeLists.txt file
* Remove dublicate install command
* Export ${PROJECT_NAME}Targets

(cherry picked from commit 8fddbda)

# Conflicts:
#	moveit_ros/warehouse/CMakeLists.txt
tylerjw pushed a commit that referenced this pull request Oct 28, 2022
* Restructure warhouse package to match other packages, remove manifest.xml
* Cleanup CMakeLists.txt file
* Remove dublicate install command
* Export ${PROJECT_NAME}Targets

(cherry picked from commit 8fddbda)
Signed-off-by: Tyler Weaver <tyler@picknik.ai>

# Conflicts:
#	moveit_ros/warehouse/CMakeLists.txt
tylerjw pushed a commit that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants