-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure moveit warehouse package #1551
Restructure moveit warehouse package #1551
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1551 +/- ##
==========================================
- Coverage 51.12% 51.10% -0.02%
==========================================
Files 380 380
Lines 31802 31802
==========================================
- Hits 16256 16249 -7
- Misses 15546 15553 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cleanup looks very reasonable, thank you!
This pull request is in conflict. Could you fix it @sjahr? |
50d3b85
to
ec07a9e
Compare
@henningkayser can you re-trigger CI, the servo tests failed |
* Restructure warhouse package to match other packages, remove manifest.xml * Cleanup CMakeLists.txt file * Remove dublicate install command * Export ${PROJECT_NAME}Targets (cherry picked from commit 8fddbda) # Conflicts: # moveit_ros/warehouse/CMakeLists.txt
* Restructure warhouse package to match other packages, remove manifest.xml * Cleanup CMakeLists.txt file * Remove dublicate install command * Export ${PROJECT_NAME}Targets (cherry picked from commit 8fddbda) Signed-off-by: Tyler Weaver <tyler@picknik.ai> # Conflicts: # moveit_ros/warehouse/CMakeLists.txt
Description
Remove manifest.xml and Makefile and restructure package from
to
Checklist