Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Used C++ style cast instead of C style cast #1628

Merged
merged 9 commits into from
Nov 18, 2022
Merged

Used C++ style cast instead of C style cast #1628

merged 9 commits into from
Nov 18, 2022

Conversation

abhijelly
Copy link
Contributor

Description

Please explain the changes you made, including a reference to the related issue if applicable

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Oct 20, 2022 •
edited
Loading

Codecov Report

Base: 50.97% // Head: 50.97% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (337786a) compared to base (b6fcac8).
Patch coverage: 45.00% of modified lines in pull request are covered.

❗ Current head 337786a differs from pull request most recent head 809afd7. Consider uploading reports for the commit 809afd7 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1628      +/-   ##
==========================================
+ Coverage   50.97%   50.97%   +0.01%     
==========================================
  Files         378      378              
  Lines       31658    31653       -5     
==========================================
- Hits        16135    16133       -2     
+ Misses      15523    15520       -3
Impacted Files Coverage Δ
...e/collision_detection_fcl/src/collision_common.cpp 73.76% <ø> (ø)
...tance_field/src/collision_distance_field_types.cpp 35.65% <0.00%> (ø)
...nstraint_samplers/src/constraint_sampler_tools.cpp 0.00% <0.00%> (ø)
.../ompl_interface/src/detail/constrained_sampler.cpp 0.00% <0.00%> (ø)
.../ompl_interface/src/detail/constraints_library.cpp 0.00% <0.00%> (ø)
...ccupancy_map_monitor/src/occupancy_map_updater.cpp 0.00% <ø> (ø)
...it_core/robot_state/src/cartesian_interpolator.cpp 39.14% <50.00%> (ø)
.../distance_field/src/propagation_distance_field.cpp 93.84% <60.00%> (ø)
...kinematic_constraints/src/kinematic_constraint.cpp 74.24% <100.00%> (ø)
...eit_core/robot_trajectory/src/robot_trajectory.cpp 67.06% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@abhijelly abhijelly changed the title Used C++ style cast instead of C style cast for unsigned int type Used C++ style cast instead of C style cast Oct 20, 2022
henningkayser
henningkayser reviewed Oct 28, 2022
View reviewed changes
Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this cleanup. All casts look correct to me, just some comments before approval.

moveit_core/robot_state/test/robot_state_test.cpp Outdated Show resolved Hide resolved
moveit_planners/ompl/ompl_interface/test/test_ompl_constraints.cpp Outdated
@@ -230,7 +230,7 @@ class TestOMPLConstraints : public ompl_interface_testing::LoadTestRobot, public

for (std::size_t i = 0; i < num_dofs_; ++i)
{
EXPECT_EQ(joint_limits[i]->size(), (unsigned int)1);
EXPECT_EQ(joint_limits[i]->size(), static_cast<unsigned int>(1));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

moveit_setup_assistant/moveit_setup_srdf_plugins/src/compute_default_collisions.cpp Outdated Show resolved Hide resolved
@abhijelly
Copy link
Contributor Author

Thank you for this cleanup. All casts look correct to me, just some comments before approval.

Done!

@henningkayser henningkayser added the backport-humble Mergify label that triggers a PR backport to Humble label Nov 10, 2022
@tylerjw tylerjw self-assigned this Nov 18, 2022
@henningkayser henningkayser merged commit 99a4a43 into moveit:main Nov 18, 2022
mergify bot pushed a commit that referenced this pull request Nov 18, 2022
@abhijelly @mergify
Used C++ style cast instead of C style cast (#1628)
31b660f 
Co-authored-by: Henning Kayser <henningkayser@picknik.ai>
(cherry picked from commit 99a4a43)
@mergify mergify bot mentioned this pull request Nov 18, 2022
Closed
@ChrisThrasher ChrisThrasher mentioned this pull request Nov 30, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abishalini Abishalini Abishalini left review comments

@tylerjw tylerjw tylerjw approved these changes

@henningkayser henningkayser henningkayser approved these changes

Assignees

@tylerjw tylerjw

Labels
backport-humble Mergify label that triggers a PR backport to Humble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abhijelly @tylerjw @henningkayser @Abishalini