-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ruckig termination condition #1963
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1963 +/- ##
==========================================
- Coverage 50.31% 50.16% -0.14%
==========================================
Files 374 374
Lines 31358 31354 -4
==========================================
- Hits 15774 15726 -48
- Misses 15584 15628 +44
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Can you link to the issue that this is fixing? |
cc58029
to
ee6d247
Compare
moveit_core/trajectory_processing/test/test_ruckig_traj_smoothing.cpp
Outdated
Show resolved
Hide resolved
ee6d247
to
003d748
Compare
c0f73b5
to
5ac13f4
Compare
5ac13f4
to
572014b
Compare
|
Description
Previously I didn't understand the difference between
ruckig::Finished
andruckig::Working
so I focused only onruckig::Finished
. There's not much documentation but here it is: https://github.com/pantor/ruckig/blob/master/include/ruckig/result.hppThis corrects that error and adds a comment. Fixes #1960
This should significantly speed up Ruckig-smoothed trajectories. I'm seeing speedups in the range of 50% although it depends on the specific robot configuration.
Fixes #1960. It is a port of this MoveIt1 PR: moveit/moveit#3348
@swiz23 @mechwiz @nbbrooks
Plots. The performance is close to optimal but not quite optimal. This makes sense because the iterative process for multiple waypoints involves extending durations in 10% increments -- so it could be up to 10% non-optimal.
J1, vel limit=2.18 rad/s, accel limit=3.75 rad/s^2, jerk limit=100
![j1](https://user-images.githubusercontent.com/11284393/221287925-3a1640a1-8ec9-49e3-87f4-cada2742b36c.png)
J3, vel limit=2.18, accel limit=2.5, jerk limit=100
![j3](https://user-images.githubusercontent.com/11284393/221287954-9b041045-9054-462c-806c-1b5f6353a079.png)