New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linking error with cached_ik_kinematics_plugin #2292
Fix linking error with cached_ik_kinematics_plugin #2292
Conversation
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix! I agree that the base library seems to be superfluous.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2292 +/- ##
==========================================
- Coverage 50.72% 50.70% -0.01%
==========================================
Files 386 386
Lines 31914 31914
==========================================
- Hits 16185 16179 -6
- Misses 15729 15735 +6 ☔ View full report in Codecov by Sentry. |
Minor blocker for this: #2293 |
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested this out. Thanks for fixing this
…2300) * Fix linking error with cached_ik_kinematics_plugin Signed-off-by: Shane Loretz <sloretz@intrinsic.ai> (cherry picked from commit 4c901b2) * Add PUBLIC/PRIVATE keywords Signed-off-by: Shane Loretz <sloretz@intrinsic.ai> (cherry picked from commit 68a6ee2) --------- Co-authored-by: Shane Loretz <sloretz@intrinsic.ai>
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Description
This fixes a bug caused by #1677 which accidentally inverted the dependency between the plugin and the base library. This fixes it by making the plugin again depend on the base library, and adding missing dependencies to the base library.
I'm not sure why the base library is necessary. It seems like we could add
ik_cache.cpp
to the plugin library, but I fixed it this way because I would like to request this fix be backported to ROS Iron.Steps to reproduce (sorry I didn't spend the time to make an MRE)
moveit_ros_move_group move_group
node with parameters that includesChecklist