Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generate_parameter_library to load cached IK kinematics parameters #1677

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

Abishalini
Copy link
Contributor

Description

Use generate_parameter_library to load cached ik kinematics parameters

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 51.07% // Head: 51.07% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (800616e) compared to base (bd9a9e8).
Patch has no changes to coverable lines.

❗ Current head 800616e differs from pull request most recent head 69d11e9. Consider uploading reports for the commit 69d11e9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1677      +/-   ##
==========================================
+ Coverage   51.07%   51.07%   +0.01%     
==========================================
  Files         381      381              
  Lines       31743    31746       +3     
==========================================
+ Hits        16208    16210       +2     
- Misses      15535    15536       +1     
Impacted Files Coverage Δ
...ma_kinematics_plugin/src/lma_kinematics_plugin.cpp 77.17% <0.00%> (-0.19%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small nit, otherwise this is good to go

@tylerjw tylerjw force-pushed the cached_ik_kinematics_parameters branch from 800616e to 69d11e9 Compare October 31, 2022 18:46
@tylerjw tylerjw merged commit 6c2d1c1 into moveit:main Oct 31, 2022
@Abishalini Abishalini deleted the cached_ik_kinematics_parameters branch November 1, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants