Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depth_image_octomap_updater porting error #383

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

RoboticsYY
Copy link
Contributor

@RoboticsYY RoboticsYY commented Mar 15, 2021

Description

This PR intends to address the errors in depth_image_octomap_updater that were not covered in the porting PR #354.

Test the PR through the sample below:

moveit_ros_depth_image_octomap_updater

Checklist

@RoboticsYY RoboticsYY changed the title Fix depth_image_octomap_updater porting error [WIP]Fix depth_image_octomap_updater porting error Mar 15, 2021
@RoboticsYY RoboticsYY force-pushed the pr-moveit_ros_perception branch 4 times, most recently from 68021f1 to 139ff8f Compare March 16, 2021 14:50
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #383 (ef31b0c) into main (8b1784f) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head ef31b0c differs from pull request most recent head 24edf15. Consider uploading reports for the commit 24edf15 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   53.21%   53.21%   +0.01%     
==========================================
  Files         209      209              
  Lines       18805    18805              
==========================================
+ Hits        10005    10006       +1     
+ Misses       8800     8799       -1     
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 56.15% <0.00%> (-0.15%) ⬇️
...meterization/work_space/pose_model_state_space.cpp 84.56% <0.00%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b1784f...24edf15. Read the comment docs.

@RoboticsYY RoboticsYY changed the title [WIP]Fix depth_image_octomap_updater porting error Fix depth_image_octomap_updater porting error Mar 17, 2021
@henningkayser henningkayser merged commit ae0af2e into moveit:main Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants