Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move doc/ and examples to moveit2_tutorials #486

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

AdamPettinger
Copy link
Contributor

Description

See moveit/moveit2_tutorials#89 and conversation there. Moving the documentation and example executables and launch files to that repo

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice. It will make build times faster for everybody and it really belongs in the tutorials anyway.

Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think README.md should be updated, though. Since the files it refers to are getting moved.

@AdamPettinger
Copy link
Contributor Author

The tutorials PR was merged, and the Foxy Servo tutorial is live!

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #486 (a11565a) into main (2ec3e9d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #486   +/-   ##
=======================================
  Coverage   46.65%   46.65%           
=======================================
  Files         183      183           
  Lines       19654    19654           
=======================================
  Hits         9168     9168           
  Misses      10486    10486           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ec3e9d...a11565a. Read the comment docs.

@henningkayser henningkayser merged commit d54b445 into moveit:main Jun 30, 2021
@AdamPettinger AdamPettinger deleted the move_doc_to_tutorials branch June 30, 2021 15:50
nbbrooks added a commit to nbbrooks/moveit.ros.org that referenced this pull request Jul 1, 2021
AndyZe pushed a commit to moveit/moveit.ros.org that referenced this pull request Jul 1, 2021
MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants