Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port moveit ros control interface to ROS2 #545

Merged
merged 10 commits into from
Aug 30, 2021

Conversation

JafarAbdi
Copy link
Contributor

@JafarAbdi JafarAbdi commented Jul 8, 2021

Description

  • Port moveit_ros_control_interface to ROS2
  • trajectory_execution_manager: Multiple bug fixes

Currently setting moveit_manage_controllers to True will not work since controller_manager doesn't report joints names for the inactive controllers

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@JafarAbdi JafarAbdi force-pushed the pr-port_ros_interface branch 2 times, most recently from 201d00e to 9d09875 Compare July 8, 2021 13:32
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #545 (19addb4) into main (9f709a8) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #545      +/-   ##
==========================================
- Coverage   54.30%   54.28%   -0.01%     
==========================================
  Files         191      191              
  Lines       20084    20084              
==========================================
- Hits        10904    10900       -4     
- Misses       9180     9184       +4     
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 44.92% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f709a8...19addb4. Read the comment docs.

Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a high-level overview of the difference between these packages somewhere? Frankly, they all sound the same:

  • moveit_ros_control_interface: "ros_control controller manager interface for MoveIt"
  • moveit_controller_manager: I see that this is COLCON-ignored, probably will be deleted.
  • moveit_simple_controller_manager: "A generic, simple controller manager plugin for MoveIt."

It seems like moveit_ros_control_interface and moveit_simple_controller_manager should be combined into one package.

I see that moveit_ros_control_interface depends on moveit_simple_controller_manager

I won't block the PR over this comment, but it should be considered in the future.

Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think a bit of specific documentation about what these packages do would be great. Do they switch controllers when a different move group is used, or ...?

A tutorial would be great.

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing this right now...

@henningkayser henningkayser merged commit 348146f into moveit:main Aug 30, 2021
Galactic/Rolling - 2.3.0 - September 10 automation moved this from Review in progress to Done Aug 30, 2021
@JafarAbdi JafarAbdi deleted the pr-port_ros_interface branch September 29, 2021 05:49
MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants