Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reversed check #623

Merged
merged 4 commits into from
Aug 24, 2021
Merged

Conversation

nbbrooks
Copy link
Contributor

Description

Ran into this bug and found the moveit1 fix!

Port of moveit/moveit#2787

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #623 (e243232) into main (86ac9c9) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
- Coverage   54.13%   54.11%   -0.01%     
==========================================
  Files         190      190              
  Lines       20037    20037              
==========================================
- Hits        10845    10842       -3     
- Misses       9192     9195       +3     
Impacted Files Coverage Δ
.../planning_scene_monitor/src/trajectory_monitor.cpp 0.00% <0.00%> (ø)
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 74.72% <0.00%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86ac9c9...e243232. Read the comment docs.

@henningkayser henningkayser merged commit a9823b8 into moveit:main Aug 24, 2021
tylerjw pushed a commit to tylerjw/moveit2 that referenced this pull request Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants