-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CHOMP motion planner build on Windows #890
Conversation
Codecov Report
@@ Coverage Diff @@
## main #890 +/- ##
=======================================
Coverage 57.90% 57.90%
=======================================
Files 310 310
Lines 26072 26072
=======================================
Hits 15095 15095
Misses 10977 10977 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this fix.
(cherry picked from commit 0505fe3)
Description
#809 broke the build on Windows because it uses a static variable, which requires manual visibility headers in order to be exported into the DLL. This PR generates the visibility header and exports the static variable, which fixes the build. Here is a successful CI build run for Foxy.
Checklist