Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CHOMP motion planner build on Windows #890

Merged
merged 6 commits into from
Dec 22, 2021
Merged

Fix CHOMP motion planner build on Windows #890

merged 6 commits into from
Dec 22, 2021

Conversation

Ace314159
Copy link
Contributor

@Ace314159 Ace314159 commented Dec 4, 2021

Description

#809 broke the build on Windows because it uses a static variable, which requires manual visibility headers in order to be exported into the DLL. This PR generates the visibility header and exports the static variable, which fixes the build. Here is a successful CI build run for Foxy.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #890 (e2afd3b) into main (71738d9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #890   +/-   ##
=======================================
  Coverage   57.90%   57.90%           
=======================================
  Files         310      310           
  Lines       26072    26072           
=======================================
  Hits        15095    15095           
  Misses      10977    10977           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba2e77...e2afd3b. Read the comment docs.

Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix.

@henningkayser henningkayser added the backport-foxy Mergify label that triggers a PR backport to Foxy label Dec 22, 2021
@henningkayser henningkayser merged commit 0505fe3 into moveit:main Dec 22, 2021
mergify bot pushed a commit that referenced this pull request Dec 22, 2021
tylerjw pushed a commit that referenced this pull request Dec 22, 2021
Co-authored-by: Akash <Ace314159@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-foxy Mergify label that triggers a PR backport to Foxy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants